fix: set proper User-Agent header on outgoing HTTP requests#7162
Closed
MD-Mushfiqur123 wants to merge 1 commit into
Closed
fix: set proper User-Agent header on outgoing HTTP requests#7162MD-Mushfiqur123 wants to merge 1 commit into
MD-Mushfiqur123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set a meaningful
User-Agentheader on all outgoing HTTP requests, changing from the defaultgot (https://github.com/sindresorhus/got)toyarn/<version> node/<node_version>.Why
As a sys admin, I want package managers to identify themselves with a meaningful User-Agent header, but Yarn 4 currently sends "got (https://github.com/sindresorhus/got)" instead of identifying itself as Yarn. This makes it impossible to distinguish Yarn traffic and determine its exact version, preventing us from enforcing package manager allow-lists across the organization.
This follows the convention already established by npm (
npm/x.x.x node/vx.x.x) and pnpm (pnpm/x.x.x).How
YarnVersionfrom the YarnVersion moduleuser-agentheader on thegotclient, with caller-supplied headers taking precedence via spread orderingFixes #7146